openshift / openshift/osdctl

Fix stale v0.38.0 version references in harness config comments

Open Beginner friendly
#969 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ready-for-triage
Dominant language
Go
Stars
47
Forks
142
Avg merge
21h 19m
Merged PRs (30d)
9

Description

What happened

PR #968 bumped all fullsend version pins from v0.38.0 to v0.43.0. The base: URLs in .fullsend/harness/code.yaml and .fullsend/harness/triage.yaml were correctly updated to SHA 7ab05564b3c9c0ab20197e0c8572b5905ffd75ca (the v0.43.0 agents commit), but the inline comments in both files still say "pinned to agents v0.38.0" and reference "v0.38.0 fetches the work item host-side". Neither CodeRabbit's automated review nor the human reviewer (RaphaelBut) flagged the stale comments.

What could go better

The version comments should have been updated alongside the SHA pins. This is a common oversight in manual version bump PRs — the code changes (SHA, digest) are the focus, and prose comments describing the pinned version get left behind. Confidence is high that this is a genuine stale-comment bug: the comments explicitly reference "v0.38.0" while the SHAs now correspond to v0.43.0. The behavioral descriptions (e.g., "v0.38.0 fetches the work item host-side") may still be accurate for v0.43.0, but the version label is misleading regardless.

Proposed change

Update the header comments in both .fullsend/harness/code.yaml and .fullsend/harness/triage.yaml to replace all references to "v0.38.0" with "v0.43.0". Specifically:

  • In code.yaml: change "pinned to agents v0.38.0" to "pinned to agents v0.43.0" and "v0.38.0 fetches the work item host-side" to "v0.43.0 fetches the work item host-side" (lines 3 and 6 of the header comment).
  • In triage.yaml: change "pinned to agents v0.38.0" to "pinned to agents v0.43.0" and "v0.38.0 fetches the work item host-side" to "v0.43.0 fetches the work item host-side" (lines 3 and 6 of the header comment).

Note: fullsend-ai/fullsend#6589 proposes a CI check that would catch this class of stale-comment issue generically for future pin bumps.

Validation criteria

After the fix, grep -r 'v0\.38\.0' .fullsend/harness/ should return no results. The version references in both harness config comments should match the actual pinned version (v0.43.0).


Generated by retro agent from https://github.com/openshift/osdctl/pull/968

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Update the header comments in .fullsend/harness/code.yaml and .fullsend/harness/triage.yaml. Replace each v0.38.0 reference with v0.43.0, then run grep -r 'v0.38.0' .fullsend/harness/; done means the command returns no results and the comments match the pinned version.

Written by the indexing model from the issue text.

Assessment

Tech stack
yaml
Domain
tooling
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
95/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.