openshift / openshift/origin

Routers and Health Checks?

Open
#9,489 8 comments 0 reactions 1 assignee View on GitHub

@knobunc is already working on this.

Since Jun 23, 2016.

component/routing kind/question lifecycle/frozen priority/P2
Dominant language
Go
Stars
8.7k
Forks
4.8k
Avg merge
4d 10h
Merged PRs (30d)
53

Description

This is more of a RFE/question.

Right now it looks like neither the HAProxy or F5 router plugins take advantage of health checks to stop routing traffic to specific pods. Openshift is polling these via liveness probes (at what frequency?), and will eventually kill a pod, which triggers it being removed from the service, which will then be detected by the router plugin and synced with the router configuration.

Is the latency of this process already low enough (<5s) that additional health checks would not be valuable in the router?

Both HAProxy and F5 have internal support for a variety of health checks that can be used to add/remove backends from a loadbalanced group. And we are configuring liveness probes for our pods. Should liveness probes be added to the router as health checks when a route is created?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.