Log proper version of internal registry pod
Open
@dmage is already working on this.
Since Jan 15, 2018.
component/imageregistry
lifecycle/frozen
priority/P2
- Dominant language
- Go
- Stars
- 8.7k
- Forks
- 4.8k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 53
Description
Today our pod logs of internal registry shows:
time="2016-02-15T23:19:49.85726622Z" level=info msg="version=v2.1.0+unknown"
even though the version of code is v2.2.1. Compare that to the log of upstream container run manually with docker run -it registry:2.2.1:
time="2016-02-15T21:25:10.664844382Z" level=info msg="listening on [::]:5000" go.version=go1.5.2 instance.id=f5bd7081-5898-47d6-86a6-7e9682f4a0e9 service=registry version=v2.2.1
I'd certainly like to see the proper upstream version in the log. We could even extend it for the corresponding version of ose-docker-registry image (e.g. version=v2.2.1+ose-v3.1.1.902.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.