openshift / openshift/origin

SAR tests

Open
#4,306 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/security area/techdebt area/tests component/auth help wanted lifecycle/frozen priority/P2 sig/security
Dominant language
Go
Stars
8.7k
Forks
4.8k
Avg merge
4d 10h
Merged PRs (30d)
53

Description

Make a full test suite for SAR that covers these with both the current and the backwards compatible endpoints.

Personal LSAR -> allowed by local personal LSAR binding
Personal LSAR -> allowed by global personal LSAR binding
Personal LSAR -> denied by missing LSAR binding

Personal SAR without action.namespace -> allowed by global personal SAR binding
Personal SAR without action.namespace -> denied by missing SAR binding

Personal SAR with action.namespace -> allowed by global personal SAR binding and global personal LSAR binding
Personal SAR with action.namespace -> allowed by global personal SAR binding and local personal LSAR binding
Personal SAR with action.namespace -> denied by global personal SAR binding and missing LSAR binding
Personal SAR with action.namespace -> denied by missing SAR binding

Impersonal LSAR -> allowed by local LSAR binding
Impersonal LSAR -> allowed by global LSAR binding
Impersonal LSAR -> denied by local personal LSAR binding
Impersonal LSAR -> denied by global personal LSAR binding
Impersonal LSAR -> denied by missing LSAR binding

Impersonal SAR without action.namespace -> allowed by global SAR binding
Impersonal SAR without action.namespace -> denied by global personal SAR binding
Impersonal SAR without action.namespace -> denied by missing SAR binding

Impersonal SAR with action.namespace -> allowed by global SAR binding and global LSAR binding
Impersonal SAR with action.namespace -> allowed by global SAR binding and local LSAR binding
Impersonal SAR with action.namespace -> denied by global SAR binding and personal LSAR binding
Impersonal SAR with action.namespace -> denied by global personal SAR binding and LSAR binding
Impersonal SAR with action.namespace -> denied by global SAR binding and missing LSAR binding
Impersonal SAR with action.namespace -> denied by missing SAR binding

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating the existing SAR and LSAR tests and their current and backwards-compatible endpoints, then compare coverage with the listed personal and impersonal binding cases; done means every listed allow and deny scenario is covered for both endpoint versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
authorization, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.