openshift / openshift/origin

post-1.11-rebase: reenable event handling while image pruning

Open
#20,127 8 comments 0 reactions 1 assignee View on GitHub

@legionus is already working on this.

Since Jun 28, 2018.

component/image kind/bug kind/post-rebase lifecycle/frozen priority/P1 sig/developer-experience
Dominant language
Go
Stars
8.7k
Forks
4.8k
Avg merge
4d 10h
Merged PRs (30d)
53

Description

Underlying gonum/graph assigns conflicting IDs to new nodes after a node deletion. Thus two different nodes amy be assigned the same ID. This leads to panic when an edge is set between them.

The following PR temporarily disables event handling until the package is fixed. This ensures that no new nodes will be added to the graph after the first node gets removed.

https://github.com/deads2k/origin/pull/87

Either gonum/graph needs to be fixed or some replacement needs to be found.

The code is still buggy in 3.10 and needs to be fixed. The rebase just made the bug visible.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.