openshift / openshift/origin

Openshift router does not respect ingress.kubernetes.io annotations

Open
#20,009 8 comments 0 reactions 1 assignee View on GitHub

@ironcladlou is already working on this.

Since Jul 3, 2018.

lifecycle/frozen sig/network-edge
Dominant language
Go
Stars
8.7k
Forks
4.8k
Avg merge
4d 10h
Merged PRs (30d)
53

Description

Openshift router does not respect ingress.kubernetes.io annotations, when tuned for kubernetes-ingress compatibility(https://docs.openshift.org/latest/admin_guide/managing_networking.html).

Version

$ oc version
oc v3.9.0+191fece
kubernetes v1.9.1+a0ce1bc657
features: Basic-Auth GSSAPI Kerberos SPNEGO

Steps To Reproduce

I'm using the same ingress controller resource for phpmyadmin(this application is a nice example to triage the issue), deployed on Tectonic with nginx-based ingress controller, using the following annotations:

  annotations:
    ingress.kubernetes.io/add-base-url: 'true'
    ingress.kubernetes.io/rewrite-target: /

and it works.
I've enabled the ingress compatibility on Openshift. Other applications work great, especially cookie session-affinity, but phppgadmin does not. The base-url is not getting added.

Current Result

ingress.kubernetes.io annotations are ignored

Expected Result

ingress.kubernetes.io annotations should be respected. These annotations are not nginx-specific, so should be supported across all ingress-controllers.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.