Update the daemonset controller to understand upstream admission config format
Open
@aveshagarwal is already working on this.
Since Apr 6, 2018.
kind/delivery-blocker
lifecycle/frozen
priority/P1
- Dominant language
- Go
- Stars
- 8.7k
- Forks
- 4.8k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 53
Description
The daemonset controller patch that is optimizing the pods being created by preventing the creation of pods that it knows will fail. The "PodNodeSelector" (the upstream one) admission plugin has a config that doesn't seem to match the "normal" flow. We need to update the controller config parser to find the value.
It'll be in vendor/k8s.io/kubernetes/cmd/kube-controller-manager/app/patch_flags.go after https://github.com/openshift/origin/pull/18989 lands.
@mfojtik @tnozicka @aveshagarwal @sjenning fyi
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.