openshift / openshift/origin

Document naming convention for UPSTREAM commits

Open
#19,126 3 comments 0 reactions 1 assignee View on GitHub

@mfojtik is already working on this.

Since Apr 9, 2018.

area/documentation area/examples lifecycle/frozen priority/P3 sig/master
Dominant language
Go
Stars
8.7k
Forks
4.8k
Avg merge
4d 10h
Merged PRs (30d)
53

Description

OpenShift uses some naming convention for UPSTREAM commits and some of them is documented here: Using hack/cherry-pick But this file lists only some keywords, not all. For instance, these are missed currently:

  • UPSTREAM: revert: ...
  • UPSTREAM: company/component: ...

In other words, we need to sync the doc with a tool:
https://github.com/openshift/origin/blob/3f52063c7ff4046a1ecbf931fa9724408b3a2e1e/tools/rebasehelpers/commitchecker/validate.go#L19-L38

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.