openshift / openshift/origin

Router should be accept proxy protocol on port 1936

Open
#17,619 6 comments 0 reactions 1 assignee View on GitHub

@knobunc is already working on this.

Since Dec 6, 2017.

component/routing kind/bug lifecycle/frozen priority/P2
Dominant language
Go
Stars
8.7k
Forks
4.8k
Avg merge
4d 10h
Merged PRs (30d)
53

Description

I'm using on the AWS the new NLB for loadbalancing the router.

AWS supports the proxy protocol days ago. I configure the IP:1936/healthz as healthcheck.

If the target group of the loadbalancer has active proxy protocol, the healthcheck are fired with proxy protocol, too. Since the port 1936 is handeld by the openshift-router process, it must be accept the proxy protocol to response valid answers for the loadbalancer.

Version

oc version

oc v3.7.0+7ed6862
kubernetes v1.7.6+a08f5eeb62
features: Basic-Auth GSSAPI Kerberos SPNEGO

Server
openshift v3.7.0+7ed6862
kubernetes v1.7.6+a08f5eeb62

Steps To Reproduce
  1. Setup a multiple Openshift Routers with active PROXY_PROTOCOL support.
  2. In AWS, setup a network loadbalancer, a target group (use ip as target instead instances!), define the healthcheck to HTTP:1936/healthz and enable the proxy protocol
Current Result

After some minutes, the health status will be unhealthy

Expected Result

All Target should be healthy

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.