openshift / openshift/origin

followups to build webhook trigger secret references

Open
#17,496 5 comments 0 reactions 1 assignee View on GitHub

@bparees is already working on this.

Since Nov 28, 2017.

area/techdebt component/build lifecycle/frozen priority/P2
Dominant language
Go
Stars
8.7k
Forks
4.8k
Avg merge
4d 10h
Merged PRs (30d)
53

Description

Follow ups to:
https://github.com/openshift/origin/pull/17314

  • buildtriggercause includes the secret value partially masked. should not expose it at all: https://github.com/openshift/origin/pull/18389
  • webhook trigger docs needs updating: https://github.com/openshift/openshift-docs/pull/6552
  • quickstarts need to be updated to use the new reference mechanism
  • new-app needs to be updated to produce webhook triggers that use secret refs
  • do we care about the clutter of secrets that will be left behind when people delete their buildconfigs? should we use GC to clean them up?

Unfortunately changes to new-app and the quickstarts won't be backwards compatible, so we can't change new-app until 3.10. Not sure when we'd want to change the quickstarts.

/cc @jim-minter

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.