openshift / openshift/origin

The oc set resources command should work for buildconfigs.

Open
#17,311 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

component/cli kind/feature lifecycle/frozen lifecycle/stale priority/P2
Dominant language
Go
Stars
8.7k
Forks
4.8k
Avg merge
4d 10h
Merged PRs (30d)
53

Description

Should be able to use oc set resources on buildconfigs.

$ oc set resources bc/blog --limits memory=786Mi
error: buildconfigs/blog the object is not a pod or does not have a pod template
Version
oc v3.6.1+008f2d5
kubernetes v1.6.1+5115d708d7
features: Basic-Auth

Server https://api.pro-us-east-1.openshift.com:443
openshift v3.6.173.0.21
kubernetes v1.6.1+5115d708d7
Steps To Reproduce

Run oc set resources on a build config.

Current Result

Will fail.

Expected Result

Should be able to work.

Additional Information

None.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation and tests for the oc set resources command, then trace why buildconfigs are rejected as lacking a pod template. Reproduce the reported command and add support so resource limits can be applied to a buildconfig, with tests confirming the command succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes
Domain
build-system, cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.