openshift / openshift/origin

Delete logic in tests around systemOnly roles

Open
#17,257 4 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

area/techdebt component/auth lifecycle/frozen priority/P2
Dominant language
Go
Stars
8.7k
Forks
4.8k
Avg merge
4d 10h
Merged PRs (30d)
53

Description

It was a good idea at the time and caught a couple bugs, but in reality it just doesn't work.

It blocks OpenShift working seamlessly on top of Kubernetes because it assumes we have ownership of Kubernetes resources. Also it is impossible to get plugin authors (such as the service catalog) to annotate their roles with systemOnly. Our tests only cover bootstrapping, so these roles will incorrectly appear in the web console anyway.

We have reimplemented a whitelist in the console already.

@enj @jwforres @spadgett

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.