openshift / openshift/origin

Correctly handle custom resource.group with SAR commands

Open
#16,648 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area/security component/auth lifecycle/frozen priority/P2 sig/security
Dominant language
Go
Stars
8.7k
Forks
4.8k
Avg merge
4d 10h
Merged PRs (30d)
53

Description

Commands like can-i and who-can do the wrong SAR when the resource.group does not have a rest mapper (custom resource that is not part of the API).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the can-i and who-can command paths and trace how a custom resource.group is resolved when no REST mapper entry exists. Reproduce the incorrect SAR with such a resource, then verify that both commands select the correct SAR behavior for unmapped custom groups.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
authorization, cli
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.