DeplymentController uses an unusual construct for getByKey
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 8.7k
- Forks
- 4.8k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 53
Description
I found this https://github.com/openshift/origin/blob/0c81307bf6eb180d27427e67bb9f0996426e04f8/pkg/deploy/controller/deployer/factory.go#L219-L222 which I had to fix in image controller in https://github.com/openshift/origin/pull/15927.
I'm guessing @tnozicka you'll be the best person to address the same issue in deployments. Generally getByKey should not interpret errors.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pkg/deploy/controller/deployer/factory.go at lines 219-222 and compare the related fix in image controller PR 15927. Confirm how getByKey handles errors, then update the deployment controller so it does not interpret them; done means the deployment path follows the intended error behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- backend, devops
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100