openshift / openshift/origin

RBAC Migration Followup #1: Proxied endpoint

Open
#15,813 3 comments 0 reactions 1 assignee View on GitHub

@simo5 is already working on this.

Since Aug 22, 2017.

area/security area/techdebt component/auth help wanted lifecycle/frozen priority/P2 sig/security
Dominant language
Go
Stars
8.7k
Forks
4.8k
Avg merge
4d 10h
Merged PRs (30d)
53

Description

  • Should delete with proxy return details?
  • Fix proxied create: _ bool is includeUnintialized, which we should really be passing through to the underlying API... it's odd there's not a CreateOptions parameter to Create
  • Fix proxied update: if initializers use Update() to initialize objects (which I think they do), we may need to pass GetOptions{IncludeUninitialized: true} here...

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.