oauthclientauthorizations do not check the client's UID
Open
Nobody has claimed this yet.
area/security
component/auth
lifecycle/frozen
lifecycle/stale
priority/P2
- Dominant language
- Go
- Stars
- 8.7k
- Forks
- 4.8k
- Avg merge
- 4d 10h
- Merged PRs (30d)
- 53
Description
We do not honor oauthclientauthorizations whose user UID does not match. However, we do not track the client's UID so an oauthclientauthorization will match a client that has been deleted and recreated.
This would be mitigated if #15120 was fixed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the oauthclientauthorization matching logic and how client identity is represented. Read issue #15120 for the stated mitigation and trace the behavior when a client is deleted and recreated. Done means an authorization cannot match a recreated client with a different UID, with coverage for that case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- authentication, authorization
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100