openshift / openshift/openshift-velero-plugin

Cluster_Arch overridable

Open
#271 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lifecycle/frozen
Dominant language
Go
Stars
55
Forks
45
Avg merge
3d 10h
Merged PRs (30d)
11

Description

CLUSTER_OS ?= $(shell $(OC_CLI) get node -o jsonpath='{.items[0].status.nodeInfo.operatingSystem}' 2> /dev/null)
CLUSTER_ARCH ?= $(shell $(OC_CLI) get node -o jsonpath='{.items[0].status.nodeInfo.architecture}' 2> /dev/null)

For followup.

Originally posted by @kaovilai in https://github.com/openshift/openshift-velero-plugin/pull/268#discussion_r1705712797

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the existing CLUSTER_OS and CLUSTER_ARCH definitions that query OC_CLI, then compare them with the linked suggestion. Verify that callers can provide both variables without triggering the default cluster queries, while unset variables still receive those defaults.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes, shell
Domain
build-system, infrastructure
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.