openshift / openshift/ocm-agent-operator

Track removal of local sandbox policy workaround when fullsend #2264 lands

Open
#344 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

ready-for-triage
Dominant language
Go
Stars
3
Forks
59
Avg merge
10h 17m
Merged PRs (30d)
25

Description

What happened

PR #343 introduced local sandbox policy files (.fullsend/policies/triage.yaml, .fullsend/policies/code.yaml) and pinned them in the harness configs (.fullsend/harness/triage.yaml, .fullsend/harness/code.yaml) as a workaround for fullsend #2264, which tracks the gap where forge selection doesn't switch to jira for Jira-triggered dispatches. The PR also added an ISSUE_NUMBER: "0" placeholder in the code harness because the reusable-dispatch harness-run job doesn't map ISSUE_NUMBER from the pre-computed matrix for the Jira path. The fullsend review agent's first run flagged the absence of an inline tracking mechanism for this workaround. The PR was the fourth in a series (#337, #338, #341, #343) iteratively building Jira poll dispatch support.

What could go better

When fullsend #2264 is resolved and the platform natively selects the Jira forge (applying the correct sandbox policy automatically), the local policy overrides and the ISSUE_NUMBER placeholder should be removed. Without a tracking issue, these workaround files are likely to persist as silent technical debt — they won't cause failures but will diverge from the platform's intended configuration model and could conflict with future policy updates. Confidence is high: the PR description, inline comments, and the review agent all explicitly characterize these files as temporary workarounds for a specific upstream gap.

Proposed change

Create a tracking issue in openshift/ocm-agent-operator listing the specific artifacts to clean up once fullsend #2264 is resolved:

  1. Remove .fullsend/policies/triage.yaml and .fullsend/policies/code.yaml (local policy overrides)
  2. Remove the policy: key from .fullsend/harness/triage.yaml and .fullsend/harness/code.yaml (let the platform select the correct policy via forge detection)
  3. Remove the ISSUE_NUMBER: "0" placeholder from .fullsend/harness/code.yaml
  4. Verify the Jira poll dispatch workflow (.github/workflows/fullsend-poll-jira.yaml) still functions correctly with native forge selection

The issue should reference fullsend #2264 as a blocking dependency and link back to PR #343 for context.

Validation criteria

A tracking issue exists in openshift/ocm-agent-operator that references fullsend #2264 and enumerates the specific files and config lines to revert. The issue is linked (via comment or cross-reference) from fullsend #2264 so that resolution of the upstream issue triggers awareness of the downstream cleanup.


Generated by retro agent from https://github.com/openshift/ocm-agent-operator/pull/343

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking fullsend #2264 and PR #343, then inspect the listed .fullsend policy and harness files plus .github/workflows/fullsend-poll-jira.yaml. After the upstream fix lands, remove the documented local overrides and ISSUE_NUMBER placeholder, verify Jira poll dispatch still works, and link the cleanup back to fullsend #2264.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, yaml
Domain
ci-cd, devops
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.