openshift / openshift/oadp-operator
Standardize time fields from DPA when API version updates
Open
Nobody has claimed this yet.
lifecycle/frozen
- Dominant language
- Go
- Stars
- 92
- Forks
- 93
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 43
Description
There are several time fields in DPA, some being
spec.configuration.velero.args.backup-sync-periodspec.configuration.velero.args.default-backup-ttlspec.configuration.velero.args.default-item-operation-timeoutspec.configuration.velero.args.default-repo-maintain-frequencyspec.configuration.velero.args.fs-backup-timeoutspec.configuration.velero.args.garbage-collection-frequencyspec.configuration.velero.args.item-operation-sync-frequencyspec.configuration.velero.args.resource-timeoutspec.configuration.velero.args.store-validation-frequencyspec.configuration.velero.args.terminating-resource-timeoutspec.configuration.nodeAgent.timeoutspec.backupLocations[].velero.backupSyncPeriodspec.configuration.velero.defaultItemOperationTimeoutspec.configuration.velero.resourceTimeout
And they are typed as string, metav1.Duration and time.Duration.
They should be all be the same type, for improved user and developer experience. They should also be validated in validators.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the listed DPA time fields through the API definitions and validators, comparing their current string, metav1.Duration, and time.Duration types across API versions. Done means the fields use a consistent type and validation is present for each affected field.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, infrastructure
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100