openshift / openshift/oadp-operator

Standardize time fields from DPA when API version updates

Open
#1,295 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lifecycle/frozen
Dominant language
Go
Stars
92
Forks
93
Avg merge
1d 23h
Merged PRs (30d)
43

Description

There are several time fields in DPA, some being

  • spec.configuration.velero.args.backup-sync-period
  • spec.configuration.velero.args.default-backup-ttl
  • spec.configuration.velero.args.default-item-operation-timeout
  • spec.configuration.velero.args.default-repo-maintain-frequency
  • spec.configuration.velero.args.fs-backup-timeout
  • spec.configuration.velero.args.garbage-collection-frequency
  • spec.configuration.velero.args.item-operation-sync-frequency
  • spec.configuration.velero.args.resource-timeout
  • spec.configuration.velero.args.store-validation-frequency
  • spec.configuration.velero.args.terminating-resource-timeout
  • spec.configuration.nodeAgent.timeout
  • spec.backupLocations[].velero.backupSyncPeriod
  • spec.configuration.velero.defaultItemOperationTimeout
  • spec.configuration.velero.resourceTimeout

And they are typed as string, metav1.Duration and time.Duration.

They should be all be the same type, for improved user and developer experience. They should also be validated in validators.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the listed DPA time fields through the API definitions and validators, comparing their current string, metav1.Duration, and time.Duration types across API versions. Done means the fields use a consistent type and validation is present for each affected field.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, infrastructure
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.