openshift / openshift/oadp-operator
DPAReconciler already have a logger, use it instead of passing to each reconcile functions
Open
Nobody has claimed this yet.
good first issue
lifecycle/frozen
priority/backlog
- Dominant language
- Go
- Stars
- 92
- Forks
- 93
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 43
Description
// TODO: DPAReconciler already have a logger, use it instead of passing to each reconcile functions
https://github.com/openshift/oadp-operator/blob/master/controllers/dpa_controller.go#L216
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at controllers/dpa_controller.go around line 216 and inspect DPAReconciler plus the reconcile functions that currently receive a logger. Trace how the existing reconciler logger is initialized and passed through the call chain. Done means those functions use the reconciler's logger without receiving it as a separate argument, with the relevant Go tests still passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- devops
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100