openshift / openshift/installer
Retry SSH without SSH_AUTH_SOCK
Open
Nobody has claimed this yet.
lifecycle/frozen
- Dominant language
- Go
- Stars
- 1.6k
- Forks
- 1.5k
- Avg merge
- 5d 5h
- Merged PRs (30d)
- 39
Description
On darwin, this is set by default.. may be wise to retry without inheriting this env on darwin on all ssh ops such as gather bootstrap.
https://github.com/openshift/installer/blob/08aa270e20db77b237306b3f3700d6b2ad654abc/pkg/gather/ssh/agent.go#L15-L25
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/gather/ssh/agent.go lines 15-25 and trace the other SSH operation entry points mentioned in the issue. Check how SSH_AUTH_SOCK is inherited on Darwin and identify the existing retry flow; done means the relevant SSH operations handle the Darwin case consistently, with tests or verification covering the behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- infrastructure
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 38/100