fix(nodepool): scope autoRepair/ignition gate to regular MHC only instead of returning from entire CAPI Reconcile
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
Research direction
Start with the CAPI.Reconcile function and PR #8645, including the linked reviewer discussion, to understand the current autoRepair and ReachedIgnitionEndpoint gate. Ensure that an unreached ignition endpoint skips only regular MHC reconciliation while MachineDeployment and subsequent reconciliation continue normally; run the relevant controller tests if available.
Written by the indexing model from the issue text.
Description
Background
In PR #8645 we moved the spot MHC reconciliation before the autoRepair/ReachedIgnitionEndpoint gate in CAPI.Reconcile() to fix a bug where the spot MHC was never created when ignition wasn't reached.
However, the current gate still returns nil from the entire Reconcile function when autoRepair is enabled but ignition hasn't been reached. This means everything after the gate (MachineDeployment reconciliation, etc.) is also skipped.
Proposed Change
Refactor the gate so it only affects regular MHC creation:
- Instead of
return nilwhen ignition isn't reached, skip only the regular MHC reconciliation - Allow the rest of
Reconcile()(MachineDeployment, etc.) to proceed normally
Context
- Dominant language
- Go
- Stars
- 542
- Forks
- 567
- Avg merge
- 5d 13h
- Merged PRs (30d)
- 136
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from openshift/hypershift
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
openshift/hypershift#8930 ·
-
lifecycle/stale
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
openshift/hypershift#8736 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 68/100
openshift/hypershift#9536 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 74/100
openshift/hypershift#9509 ·
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
openshift/hypershift#9402 · 1 comment ·
All issues in openshift/hypershift
Similar issues
-
optimization optimization:agents-md-curator
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
githubnext/gh-aw-cao#13143 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
blinklabs-io/bursa#904 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
yanet-platform/ipfw-go#129 ·
-
bug confmap/provider/googlesecretmanagerprovider needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
open-telemetry/opentelemetry-collector-contrib#51273 · 2 comments ·
-
bug: AI Gateway client filter lists "Unknown" twice when NULL and literal Unknown clients coexist Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 90/100