openshift / openshift/file-integrity-operator
End to end tests broke including the namespace in alerts
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 34
- Forks
- 37
- Avg merge
- 6d 1h
- Merged PRs (30d)
- 3
Description
We recently merged support for including the namespace in the NodeHasIntegrityFailure alert [0].
This helps understand where the alert is coming from, but we have some assertions in the end-to-end tests that appear to fail with this new format [1].
Opening this issue to track the work to get e2e tests running again.
[0] https://github.com/openshift/file-integrity-operator/commit/af58faa27382412cefe18435baf4de0b236c40f0
[1] https://github.com/openshift/file-integrity-operator/blob/master/tests/e2e/e2e_test.go#L56
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with tests/e2e/e2e_test.go at line 56 and compare its alert assertions with the namespace-inclusive NodeHasIntegrityFailure format introduced in commit af58faa27382412cefe18435baf4de0b236c40f0. Run the end-to-end tests to identify the failing assertions; done means the assertions match the new alert format and the e2e tests run successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100