openshift / openshift/cloud-credential-operator

RFE: Add readinessProbe to Deployment manifest

Open
#859 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

lifecycle/frozen
Dominant language
Go
Stars
75
Forks
196
Avg merge
8d 13h
Merged PRs (30d)
5

Description

https://github.com/openshift/cloud-credential-operator/blob/6a880b473554aee4d1f3cd125048fef2bca6a04d/manifests/03-deployment.yaml#L34

I have encountered situations where the CCO controller Pod is not functioning and regularly crashing, but due to no readinessProbe, looks fine on the surface. This has happened with the CCO in Mint Mode while using an AWS Provider when the kube-system/aws-creds information becomes invalid due to IAM access/secret keys being deactivated after a rotation.

I have previously seen messages in the logs indicating AWS permission issues, but lately the CCO container logs are silent. The only symptom was never-ending messages like these in the CCO Pod's kube-rbac-proxy container's logs:

I0519 19:48:43.671759 1 log.go:245] http: proxy error: dial tcp 127.0.0.1:2112: connect: connection refused

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with manifests/03-deployment.yaml at line 34, then use the reported kube-rbac-proxy connection-refused symptom to identify the readiness signal. Done means the deployment manifest includes a readinessProbe that keeps a non-functioning CCO Pod from being reported ready.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes
Domain
devops, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.