openshift / openshift/aws-vpce-operator

Add integration coverage for Route53 record retry-cap requeue

Open
#461 0 comments 0 reactions 1 assignee View on GitHub

@dustman9000 is already working on this.

Since Jul 30, 2026.

Dominant language
Go
Stars
8
Forks
55
Avg merge
1d 5h
Merged PRs (30d)
4

Description

Summary

Add envtest or integration-level coverage for the retry-cap path introduced in PR #460. When VPC endpoint validation fails after the VPC endpoint is ready but the Route 53 record is not ready, reconciliation should suppress that validation error and return a fixed one-minute requeue delay.

Rationale

The existing unit tests cover the Route 53 tag-condition cache gate and condition persistence. The retry-cap branch is in VpcEndpointReconciler.Reconcile, and reliably asserting its returned ctrl.Result requires a reconciler-level environment.

Affected area

  • controllers/vpcendpoint/vpcendpoint_controller.go
  • New or existing envtest/integration test infrastructure for the VpcEndpoint reconciler

Acceptance criteria

  • Set up a VpcEndpoint state where AWSVpcEndpointReady=True, AWSRoute53RecordReady is not True, and resource validation returns an error.
  • Invoke reconciliation through an envtest or integration-level test.
  • Assert reconciliation returns no error.
  • Assert ctrl.Result.RequeueAfter == time.Minute.
  • Assert the behavior remains scoped to this condition combination; unrelated validation errors must continue to be returned normally.

Backlinks

Requested by @dustman9000.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.