opensearch-project / opensearch-project/sql
Remove OpenSearchRelevanceFunctionPushdownRule once we remove `calcite no pushdown` cluster setting.
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 176
- Forks
- 229
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 43
Description
We have introduced new push down rule OpenSearchRelevanceFunctionPushdownRule to circumvent no calcite pushdown setting in case of search commands.
Search commands by default gets converted to query_string relevance function and Lucene query. But, we want search queries to be pushed down irrespective of the plugins.calcite.pushdown.enabled cluster setting.
Since, in the long term we plan to remove plugins.calcite.pushdown.enabled setting, we want the above rule to be deleted with the removal of above setting.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading OpenSearchRelevanceFunctionPushdownRule and tracing references to the plugins.calcite.pushdown.enabled cluster setting. Confirm that the setting has been removed, then remove the rule and its remaining references; done means search commands still push down without the setting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100