opensearch-project / opensearch-project/sql-jdbc
Implementation of isValid for the JDBC driver
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 28
- Forks
- 39
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem? Please describe.
The lack of implementation of isValid() may be the root cause of inconsistencies in the TDVT test results.
Describe the solution you'd like
It would be great if isValid() is completely implemented similar to https://github.com/pgjdbc/pgjdbc/blob/bf00387461bafdf0f19a8557bff554e469207cce/pgjdbc/src/main/java/org/postgresql/jdbc/PgConnection.java so that it does not always return true.
Additional context
https://github.com/opensearch-project/sql/blob/main/sql-jdbc/src/main/java/org/opensearch/jdbc/ConnectionImpl.java#L421
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at sql-jdbc/src/main/java/org/opensearch/jdbc/ConnectionImpl.java around line 421 and compare the existing isValid() behavior with the referenced pgjdbc implementation. Determine how the JDBC driver should validate its connection rather than always returning true, then verify the behavior against the TDVT results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- database
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100