opensearch-project / opensearch-project/sql-cli
[FEATURE] Support IPv6 addresses
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Python
- Stars
- 9
- Forks
- 24
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem?
$ opensearchsql fe80::df26:c460:e530:123b:9200
Traceback (most recent call last):
File "/home/yuryf/.local/bin/opensearchsql", line 11, in <module>
load_entry_point('opensearchsql', 'console_scripts', 'opensearchsql')()
File "/home/yuryf/.local/lib/python3.8/site-packages/click/core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "/home/yuryf/.local/lib/python3.8/site-packages/click/core.py", line 782, in main
rv = self.invoke(ctx)
File "/home/yuryf/.local/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/yuryf/.local/lib/python3.8/site-packages/click/core.py", line 610, in invoke
return callback(*args, **kwargs)
File "/mnt/c/GitHub/sql-cli/src/opensearch_sql_cli/main.py", line 129, in cli
opensearchsql_cli.connect(endpoint, http_auth)
File "/mnt/c/GitHub/sql-cli/src/opensearch_sql_cli/opensearchsql_cli.py", line 176, in connect
self.opensearch_executor.set_connection()
File "/mnt/c/GitHub/sql-cli/src/opensearch_sql_cli/opensearch_connection.py", line 110, in set_connection
opensearch_client = OpenSearch([self.endpoint], verify_certs=True)
File "/home/yuryf/.local/lib/python3.8/site-packages/opensearchpy/client/__init__.py", line 188, in __init__
self.transport = transport_class(_normalize_hosts(hosts), **kwargs)
File "/home/yuryf/.local/lib/python3.8/site-packages/opensearchpy/client/utils.py", line 63, in _normalize_hosts
if parsed_url.port:
File "/usr/lib/python3.8/urllib/parse.py", line 177, in port
raise ValueError(message) from None
ValueError: Port could not be cast to integer value as ':df26:c460:e530:123b:9200'
What solution would you like?
Detect and support IPv6 addresses
What alternatives have you considered?
N/A
Do you have any additional context?
N/A
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the CLI entry point in src/opensearch_sql_cli/main.py around line 129, then follow connect in src/opensearch_sql_cli/opensearchsql_cli.py and set_connection in src/opensearch_sql_cli/opensearch_connection.py around line 110. Trace how the endpoint is passed to OpenSearch and ensure IPv6 addresses no longer produce the shown port-parsing error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli, networking
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100