opensearch-project / opensearch-project/security-analytics

[BUG] Tag must start with "attack" when creating detection rule

Open
#769 4 comments 0 reactions 1 assignee View on GitHub

@sbcd90 is already working on this.

Since Apr 3, 2024.

bug
Dominant language
Java
Stars
111
Forks
111
Avg merge
1d 17h
Merged PRs (30d)
13

Description

What is the bug?
When creating a detection rule, an exception is thrown by the create/update rule API if a tag does not start with attack.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to Detection rules page
  2. Add below rule yaml in the YAML editor and hit Create
id: OFRhN4wBypPZ_lmJW5Q2
logsource:
  product: dns
title: High DNS Bytes Out cloned
description: High DNS queries bytes amount from host per short period of time
tags:
  - cve.exfiltration
  - attack.t1048.003
falsepositives:
  - >-
    Legitimate high DNS bytes out rate to domain name which should be added to
    whitelist
level: medium
status: experimental
references: []
author: 'Daniil Yugoslavskiy, oscd.community'
detection:
  selection:
    query: '*'
  timeframe: 1m
  condition: selection

What is the expected behavior?
Rule gets created but instead it shows error that tag must start with attack

What is your host/environment?

  • Security analytics all versions upto 2.11

Do you have any screenshots?
image

Do you have any additional context?
N/A

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.