opensearch-project / opensearch-project/performance-analyzer

[BUG] Debian and rpm Upgrade functionality is broken

Open
#86 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue Priority-Medium
Dominant language
Java
Stars
48
Forks
78
Avg merge
1d 2h
Merged PRs (30d)
5

Description

What is the bug?
Upgrading performance analyzer to a higher version is broken from opendistro 1.10.1.

  1. Fix the incorrect binary path in the systemd service.
  2. After manually changing the binary path, it throws error
performance-analyzer-agent-cli[2042984]: Caused by: java.lang.ClassNotFoundException: com.amazon.opendistro.elasticsearch.performanceanalyzer.PerformanceAnalyzerApp
  1. Need to revisit the postrm as it basically removes everything.
    Related issue: https://github.com/opendistro-for-elasticsearch/performance-analyzer/issues/235

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

What is the expected behavior?
A clear and concise description of what you expected to happen.

What is your host/environment?

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Plugins

Do you have any screenshots?
If applicable, add screenshots to help explain your problem.

Do you have any additional context?
Add any other context about the problem.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the Debian and rpm upgrade packaging, especially the systemd service binary path and the postrm script. Reproduce an upgrade from opendistro 1.10.1, then verify that the service starts without the reported ClassNotFoundException and that postrm removes only intended files.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.