opensearch-project / opensearch-project/data-prepper

Add error log without DataPrepperMarkers when Trace Request parsing fails

Open
#2,303 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Java
Stars
374
Forks
354
Avg merge
3d 18h
Merged PRs (30d)
8

Description

Is your feature request related to a problem? Please describe.
Add error log without input request details when trace request parsing fails.

Currently when the request parsing fails {"code":14,"grpc-code":"UNAVAILABLE"} status is returned. When Sensitive marker is enabled, there are no details why the error occurred. It would be nice to log error that the request parsing failed without logging the request.

Parsing exception thrown here.

Describe the solution you'd like
log error that the request parsing failed without logging the request data.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in data-prepper-plugins/otel-trace-source/src/main/java/org/opensearch/dataprepper/plugins/source/oteltrace/OTelTraceGrpcService.java at the parsing exception around line 98. Reproduce a trace request parsing failure with the Sensitive marker enabled and verify that an error identifies the parsing failure without including request details, while the existing failure status remains unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, observability-sre
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.