opensearch-project / opensearch-project/data-prepper

Remove support for old com.amazon.dataprepper plugin package

Open
#1,878 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breaking change
Dominant language
Java
Stars
374
Forks
354
Avg merge
3d 18h
Merged PRs (30d)
8

Description

Is your feature request related to a problem? Please describe.

Data Prepper originally loaded plugins from the com.amazon.dataprepper.plugins package. Data Prepper can now load plugins from any package so long as the plugin configures it. And by default it loads from the org.opensearch.dataprepper.plugins package. So the old package is no longer needed by default.

Support is coming from:

https://github.com/opensearch-project/data-prepper/blob/b99942c0c415dba9e825558f73500f42ebd95efe/data-prepper-main/src/main/resources/META-INF/data-prepper.plugins.properties#L6

https://github.com/opensearch-project/data-prepper/blob/b99942c0c415dba9e825558f73500f42ebd95efe/data-prepper-core/src/main/java/org/opensearch/dataprepper/plugin/PluginPackagesSupplier.java#L97

Describe the solution you'd like

Remove default support for this package by default. As this is close to the 2.0 release, I propose retaining it for 2.x and removing in 3.0.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with data-prepper-main/src/main/resources/META-INF/data-prepper.plugins.properties and data-prepper-core/src/main/java/org/opensearch/dataprepper/plugin/PluginPackagesSupplier.java, especially the referenced entries around line 6 and line 97. Confirm how the old package remains supported through 2.x, then remove its default support for 3.0 and verify plugin loading behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.