opensearch-project / opensearch-project/data-prepper
Support to remove peers from peer client poll as they exit
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 374
- Forks
- 354
- Avg merge
- 3d 18h
- Merged PRs (30d)
- 8
Description
Is your feature request related to a problem? Please describe.
Core peer forwarder currently stores all the peers in a map as they are made available but it does not remove from the map as they exit.
Describe the solution you'd like
Clean up the resources in shutdown call of PeerForwardingProcessorDecorator.
Additional context
This is the same behavior even in the peer forwarder plugin here.
There is an existing TODO in peer forwarder plugin to do it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the shutdown path in PeerForwardingProcessorDecorator, then compare the peer map behavior with PeerClientPool.java and the existing TODO in PeerForwarder.java. The change is complete when peers that exit are removed from the poller's stored resources during shutdown; identify and run the relevant peer-forwarder tests if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend, distributed-systems
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100