opensearch-project / opensearch-project/data-prepper

Create a builder for PipelineDataFlowModel and non-empty consistency between different types

Open
#1,669 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backlog
Dominant language
Java
Stars
374
Forks
355
Avg merge
3d 18h
Merged PRs (30d)
8

Description

Create a PipelineDataFlowModel.Builder class. This will allow us to remove a constructor and have only one private constructor to be used by the builder and by Jackson for JSON deserialization.

Relatedly, the PipelineDataFlowModel should use non-empty serialization for processors. It should also return an empty List<PluginModel> instead of null to provide consistency for clients.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating PipelineDataFlowModel and read its constructors, processors serialization, and PluginModel accessors. Add the Builder and verify that JSON deserialization still works, empty processors are omitted during serialization, and clients receive an empty List rather than null.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.