opensearch-project / opensearch-project/alerting
Make custom webhook host supports IP address as well
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 82
- Forks
- 133
- Avg merge
- 2d 11h
- Merged PRs (30d)
- 9
Description
Sunday Dec 29, 2019 at 17:02 GMT
Originally opened as https://github.com/opendistro-for-elasticsearch/alerting/issues/137
Hi, I have a use case that sending request to localhost with data but the host in custom attributes URL does not accept either "localhost" or "127.0.0.1". Can you consider to make it accept those values? Thanks.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the custom webhook URL behavior with localhost and 127.0.0.1, then locate the validation or request-handling entry point for custom attributes. Done means both host forms are accepted for webhook requests without breaking existing host handling, with coverage for the reported cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100