opensearch-project / opensearch-project/.github

[GitHub Request] Allow maintainers to bypsss "Require status checks to pass" for OpenSearch-Dashboards

Open
#356 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

github-request
Dominant language
No language data
Stars
41
Forks
74
Avg merge
3d 19h
Merged PRs (30d)
1

Description

What is the type of request?

Settings Update

Details of the request

This is the same request as https://github.com/opensearch-project/.github/issues/348, creating a new issue since I cannot reopen the old one.

Our ask was

  1. Enable "Require status checks to pass" for GitHub Actions starting with Build and Verify, Run cypress tests, and Lint and validate. The target branch is main and the version branches.
  2. Maintainers should be in the "Bypass list" if not already added.

Item 1 appears to be completed.

For item 2, as part of the testing guide, we agreed that maintainers should be able to override the failed actions

The workflow action should pass before PR is merged, unless maintainers override them with a comment.

Maintainer permission is defined as
https://github.com/opensearch-project/.github/blob/bb5391aa8ea54e49457c379c8357184acbca520d/RESPONSIBILITIES.md#L38

But right now I'm a maintainer, I should have maintain-level permission, yet I'm not able to override failed actions.

Is it possible to add maintain level permission to the bypass list as mentioned in item 2? This is what it should look like

Image

If it's not possible, please explain a bit with supporting references. Thanks!

Additional information to support your request

https://github.com/opensearch-project/.github/issues/348

When does this request need to be completed?

not urgent

Notes

Track the progress of your request here: https://github.com/orgs/opensearch-project/projects/208/views/33.
Member of @opensearch-project/admin will take a look at the request soon.
Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the prior request in .github issue 348, the TESTING.md section on maintainers overriding failed actions, and the maintainer definition in RESPONSIBILITIES.md. Check whether maintain-level permission can be added to the bypass list for the main and version branches; done means the bypass is configured or the limitation is documented with supporting references.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, github-actions
Domain
ci-cd, devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.