openscopeproject / openscopeproject/TrguiNG

New colored progress bars do not match current plan to make progress bar match Mac client

Open
#185 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
796
Forks
102
PR merge metrics
No merged PRs in 30d

Description

First of all, thanks for the colored progress bars. They really help with visual cues and don't impact CPU on browsers like Firefox.

There's just a few issues right now. When downloading a torrent, the progress bar is green instead of blue as it fills up to 100%
1 3

It should match the mac client which is blue when filling up to 100%

mac

As a summary:

  1. Blue when downloading (filling up) to 100% and Blue when 100% and not seeding (to match the large progress bar in the bottom details window. Not sure if the Mac client does it exactly this way but it makes more sense this way to show that blue at 100% = complete but not transferring any data to peers)
  2. Green when 100% and actively seeding to other peers. (this is currently fine)
  3. Grey when under 100% and paused (currently blue but not sure if you care to change this from blue to grey)
  4. Red when error (which I just noticed and is great!)
  5. Grey when stopped and 100% instead of dark green. (Green should only be used for actively seeding a torrent so we always know when we are actively sending data to peers)

stop

Also, the details windows at the bottom does not match what is happening in the torrent list. If a selected torrent is seeding with a green color, the details window progress bar should also say seeding in a green color.

details

See below for how the Transmission team is going to have all their official clients match the Mac client progressbar colors.

https://github.com/transmission/transmission/issues/5648

These changes should be all that is needed to make the colors consistent and match the plans for the official client. Thanks.

CC @melyux in case you think other tweaks need to be made.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named in the issue. Start by locating the colored progress-bar rendering for the torrent list and bottom details window, then compare their paused, downloading, seeding, stopped, complete, and error states; done means both views use the requested colors consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.