opensanctions / opensanctions/poliloom

Improve position overlap detection and merging logic

Open
#40 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

loom
Dominant language
Python
Stars
22
Forks
2
PR merge metrics
No merged PRs in 30d

Description

Currently, we use simple precision-based comparison for overlapping position dates during enrichment. When extracting position data, we only replace existing dates if the new ones have higher precision.

Current behavior:

  • "1962" (precision 9) gets replaced by "1962-06-15" (precision 11) ✓
  • "2010-2015" and "2010-2018" create separate records (different end dates)

Enhancement opportunity:
We could implement smarter overlap detection that:

  • Merges genuinely overlapping periods where appropriate
  • Handles extensions (2010-2015 → 2010-2018) intelligently
  • Distinguishes between partial overlaps and true conflicts

This would reduce duplicate position records while maintaining data accuracy.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the enrichment logic that compares position-date precision and trace how separate records are created for differing end dates. Before implementation, define merge rules for extensions, partial overlaps, and conflicts, then verify the listed 1962 and 2010–2018 cases with focused tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.