opensafely-core / opensafely-core/setup-action

Find a path that works for just on macos

Open
#2 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

deck-scrubbing
Dominant language
Shell
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

While we currently have no CI using the macos target, it would be useful to have at least pipeline using it since both that is used there by opensafely-cli (which should also target it). Currently this action places just in a location isn't liked by CI when called from there.

I think we have two choices:

  • set up a conditional for macos to change the output location
  • find a location that works for all OSen

I suspect there's an ideal path for each OS so it's probably easier from a future-us-debugging standpoint to do a conditional.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the action's output-location handling and reproduce the issue with a macos target, since the repository currently has no CI using it. Compare the two proposed approaches and verify the chosen location works when the action is called from CI; done means a macos pipeline can use the action successfully, including for opensafely-cli.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, macos, shell
Domain
ci-cd, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.