opensafely-core / opensafely-core/reports

Examples in `populate_reports.py` don't cover all the possible cases

Open
#633 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
0
Forks
1
Avg merge
1d 22h
Merged PRs (30d)
5

Description

It's possible for reports to be:

  • from the Bennett Institute, or owned by an organisation other than Bennett Institute
  • hosted on the reports site, or on job-server

For local development, the only examples currently in populate_reports.py are Bennett Institute reports that are hosted on the reports site.

This made checking the admin filter change in 67d8ad444e13e939c45596cf13653d348eaef1cd more work: I had to create examples manually in the admin panel first, to confirm that the code change was correct.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading reports/management/commands/populate_reports.py and its existing local-development examples. Add examples covering both Bennett Institute and other organisations, hosted on both the reports site and job-server. Verify the examples support checking the admin filter change described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
developer-experience
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.