opensafely-core / opensafely-core/reports

Migrate reports to job-server

Open
#341 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
0
Forks
1
Avg merge
1d 22h
Merged PRs (30d)
5

Description

The following reports are still consuming github outputs:

sqlite> select repo, branch, report_html_file_path, last_updated, is_draft from reports_report where job_server_url == '' order by last_updated DESC;
repo                               branch      report_html_file_path                                       last_updated  is_draft  
---------------------------------  ----------  ----------------------------------------------------------  ------------  ----------
antibody-and-antiviral-deployment  report      /reports/coverage/mabs_and_antivirals_coverage_report.html  2022-07-12    0         
nhs-covid-vaccination-coverage     main        released-outputs/vaccines-index.html                        2022-07-08    0         
nhs-covid-vaccination-coverage     main        released-outputs/opensafely_vaccine_report_overall_simple.  2022-06-29    0         
nhs-covid-vaccination-coverage     main        released-outputs/second_doses.html                          2022-06-29    0         
nhs-covid-vaccination-coverage     main        released-outputs/booster-third-doses.html                   2022-06-29    0         
nhs-covid-vaccination-coverage     main        released-outputs/first_dose_u16.html                        2022-06-29    0         
nhs-covid-vaccination-coverage     main        released-outputs/second_doses_u16.html                      2022-06-29    0         
pincer-measures                    main        released_outputs/report-combined.html                       2022-06-20    0         
database-notebooks                 master      notebooks/html/database-builds.html                         2022-06-08    0         
database-notebooks                 master      notebooks/html/database-schema.html                         2022-06-08    0         
ethnicity-short-data-report        notebook_s  local/local_report_ethnicity.html                           2022-05-30    1         
long-covid                         main        released_outputs/long_covid_coding_report.html              2022-03-17    0         
mechanical-valve-anticoag          master      /released_outputs/report_notebook.html                      2022-02-02    0         
sro-measures                       master      released_outputs/output/sentinel_measures_combined.html     2022-01-26    1         
SRO-PULSE-OXIMETRY-UPD             release-ca  released_outputs/pulse_oximetry_coding_report.html          2021-10-11    1         
comparative-ve-research            main        released_outputs/output/report/effectiveness_report.html    2021-08-26    1         
nhs-covid-vaccination-coverage     1.17        released-outputs/opensafely_vaccine_report_overall_simple.  2021-06-16    0         
sro-measures                       master      released_outputs/output/sentinel_measures_demographics.htm  2021-06-11    1         

We should move these over to consuming job-server outputs, then we can delete all the github code from reports.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the SQL query in the issue and inspect the reports code paths that consume GitHub outputs for each listed record. Trace how those reports should consume job-server outputs instead; the work is done when all listed reports use job-server outputs and the obsolete GitHub code can be removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, python
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.