opensafely-core / opensafely-core/opensafely-cli

`opensafely pull` returns a seemingly unnecessary (warning?) message about an invalid reference format

Open
#242 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
2
Forks
5
Avg merge
2d 1h
Merged PRs (30d)
4

Description

I don't know how long this has been there but I see this on the bottom line of opensafely pull output: invalid reference format, e.g.,

% opensafely pull
Updating OpenSAFELY ehrql:v1 image
v1: Pulling from opensafely-core/ehrql
Digest: sha256:33b638bb7f853639966886e0a9c9ac2e234f0b2b33be365f0a91fdfa0497f455
Status: Image is up to date for ghcr.io/opensafely-core/ehrql:v1
ghcr.io/opensafely-core/ehrql:v1

What's Next?
  View a summary of image vulnerabilities and recommendations → docker scout quickview ghcr.io/opensafely-core/ehrql:v1
Updating OpenSAFELY ehrql:<none> image
invalid reference format

I can obtain the same message seemingly about the chortextractor and r images. Maybe the message refers to the last image updated on a user's system, or something like that (I didn't trace it).

If you need it

% opensafely --version
opensafely v1.41.2

It's not clear to me what this message means but I'd say it doesn't seem necessary to report this to the user.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the output with opensafely v1.41.2 using the opensafely pull entry point, and inspect how it handles the ehrql: image update and Docker image references. Trace the source of invalid reference format; done means valid images still update and the command no longer reports a misleading error for an absent image reference.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, python
Domain
cli
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.