opensafely-core / opensafely-core/opensafely-cli

Test the build

Open
#141 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

deck-scrubbing
Dominant language
Python
Stars
2
Forks
5
Avg merge
2d 1h
Merged PRs (30d)
4

Description

It would be helpful to test that opensafely run ... executes correctly; that is, to test the build. Today, I updated job-runner in #139 but didn't add a substitute path until #140. So, if you'd run opensafely upgrade between those PRs, then you'd have found that the CLI was broken. This Slack thread has more context.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the tests and entry points for opensafely run and opensafely upgrade, then review the interaction between job-runner and the substitute path described in PRs #139 and #140. Add coverage showing that the CLI build executes correctly across that upgrade scenario, and run the relevant test suite to verify the regression is caught.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.