opensafely-core / opensafely-core/opencodelists
Make errors more visible for CSV upload on the "create a codelist" form
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 60
- Forks
- 16
- Avg merge
- 4d 12h
- Merged PRs (30d)
- 17
Description
Why are we doing this?
From @rw251 while testing #2705:
If your CSV is invalid, then after clicking Create, you are taken to the top of the page with no indication that there was a problem (other than you're not looking at the builder screen). You need to scroll down to see what the problem is.
How will we know when it's done?
When it is more obvious for a user to know that their attempt to upload a invalid CSV failed.
What are we doing?
Again, from @rw251:
We should probably have a message at the top like "There was a problem with one of the fields, please review your answers" to avoid confusion.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the create-a-codelist form and follow the invalid CSV submission and validation flow. The work is done when a failed upload produces an obvious message near the top of the page explaining that the attempt failed and the form needs review.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100