opensafely-core / opensafely-core/opencodelists
Checking behaviour when deleting searches in browser functional tests
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 60
- Forks
- 16
- Avg merge
- 4d 12h
- Merged PRs (30d)
- 17
Description
Why are we doing this?
#2421 added functional browser tests. One aspect not covered is that users can delete searches. This can have quirky behaviour (#2532, #2534). It would be good to test it more, and to help specify its intended defined behaviour.
How will we know when it's done?
When we have tests that cover, for example (but not limited to):
Case 1
- Add a search.
- Select some concepts.
- Delete the search.
Case 2
- Add a search.
- Select some concepts.
- Add a non-overlapping search.
- Select some concepts.
- Add an overlapping search.
- Select some concepts.
- Delete the original search.
Case 3
- Add a search.
- Select some concepts.
- Add a non-overlapping search.
- Select some concepts.
- Add an overlapping search.
- Select some concepts.
- Delete all searches.
What are we doing?
- Writing tests to cover at least some cases like these.
- Extending the existing test code to be able to handle deleting searches. This will need:
- some means for a test author to be able to specify a search is to be deleted
- adding a small amount of code (a couple of Playwright instructions) to actually delete the search
- ensuring we can still compute the final state correctly
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the functional browser tests added in #2421 and the existing search and final-state handling. Extend the test setup to specify searches for deletion, add the Playwright deletion steps, and cover cases such as deleting one or all searches while verifying the computed final state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- playwright, python
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100