opensafely-core / opensafely-core/opencodelists
Validate concept counts in functional tests
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 60
- Forks
- 16
- Avg merge
- 4d 12h
- Merged PRs (30d)
- 17
Description
Why are we doing this?
We update, for example, "included" and "excluded" concept counts and display these. We should ensure their correctness.
How will we know when it's done?
When we have functional tests that check their correctness.
What are we doing?
Adding checks to our existing tests, or new tests that check these values are correct as we use the codelist builder.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to existing functional tests and the codelist builder, but names no files. Locate those tests first, identify where included and excluded concept counts are produced and displayed, then add assertions for correctness and run the relevant functional test suite; done means the expected counts are checked.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100