opensafely-core / opensafely-core/backend-server

Fix RELEASE_HOST config for release-hatch deployment

Open
#40 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
1
Forks
5
Avg merge
1h 36m
Merged PRs (30d)
2

Description

RELEASE_HOST is wrongly set to http://localhost:8001 for the test-backend, which means all requests from job-server fail to validate.

Changing this to https://test.opensafely.org fixes the issue, however it breaks the functional test in release-hatch, as that was written to assume localhost. So release-hatch's functional test client needs to be able to a take a RELEASE_HOST argument, and then we can update the test here to use it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the RELEASE_HOST configuration for the test-backend and the release-hatch functional test client. Update the client to accept a RELEASE_HOST argument, then verify that the backend-server test uses https://test.opensafely.org while the functional test can still target localhost.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
devops, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.