opensafely-core / opensafely-core/backend-server
Refactor env vars for apps
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 1
- Forks
- 5
- Avg merge
- 1h 36m
- Merged PRs (30d)
- 2
Description
Apps airlock & job-runner etc share one set of env files in ~opensafely/config. This is good for some shared config (ideally job server token, although I think that's not currently working as intended) - but this leads to accidents where airlock picks up env vars intended for job-runner e.g. https://github.com/opensafely-core/airlock/pull/305 . Most relevant env vars are namespaced in airlock but this can trip up the unwary when adding new env vars.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the shared environment files in ~opensafely/config and how airlock and job-runner consume them. Review the referenced airlock change for the accidental variable pickup, then define which settings should remain shared or be namespaced. Done means the applications no longer consume each other's unintended environment variables and the job server token behavior is clarified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- shell
- Domain
- infrastructure
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100