opensafely-core / opensafely-core/backend-server

Add backend attribute to all metrics so we can filter by backend

Open
#230 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
1
Forks
5
Avg merge
1h 36m
Merged PRs (30d)
2

Description

Something like this should work, using the resource processor

However, it will require upgrading to a new version of https://github.com/honeycombio/opentelemetry-collector-configs/ first, as our current version doesn't have the resource processor

index 0510d14..dd7979a 100644
--- services/collector/collector.yaml
+++ services/collector/collector.yaml
@@ -31,6 +31,12 @@ processors:
     detectors:
       - env
       - system
+  resource:
+    # add backend attribute to all metrics if not set already
+    attributes:
+    - key: backend
+      value: "${BACKEND}"
+      action: insert
   timestamp:
     round_to_nearest: 1s
   batch:
@@ -680,6 +686,7 @@ service:
         - filter
         - timestamp
         - resourcedetection
+        - resource
         - batch
       exporters:
         - logging

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with services/collector/collector.yaml and the linked resource processor README, then identify where the current honeycombio/opentelemetry-collector-configs version is configured. Upgrade that dependency and configure the resource processor in the metrics pipeline; done means metrics include a backend attribute when one is not already set.

Written by the indexing model from the issue text.

Assessment

Tech stack
yaml
Domain
observability
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.