openrewrite / openrewrite/rewrite

Support ArtifactRegistry in MavenPomDownloader

Open
#3,370 3 comments 6 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement maven
Dominant language
Java
Stars
3.7k
Forks
570
Avg merge
13h 12m
Merged PRs (30d)
261

Description

What problem are you trying to solve?

The MavenPomDownloader supports basic authentication, (username and password). These credentials are stored in org.openrewrite.maven.tree.MavenRepository.

GCP's ArtifactRegistry has a different way of passing credentials viaartifact-registry-maven-wagon.

    <extension>
        <groupId>com.google.cloud.artifactregistry</groupId>
        <artifactId>artifactregistry-maven-wagon</artifactId>
        <version>2.2</version>
    </extension>

Describe the solution you'd like

To support GCP ArtifactRegistry we'd either have to replicate that authentication scheme, or switch over to Maven Wagon for our downloads, and gain that functionality that way. Second option perhaps best in the long run.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with rewrite-maven/src/main/java/org/openrewrite/maven/internal/MavenPomDownloader.java and the MavenRepository credentials it uses. Compare the existing basic-authentication path with the referenced artifactregistry-maven-wagon authentication scheme, then determine whether to replicate it or use Maven Wagon; done means Maven downloads from GCP Artifact Registry are supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
gcp, java
Domain
build-system, cloud
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.